refactor: remove type key from trace #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the type key from stack trace output in error messages. The type field (which shows the call type like -> for instance methods or :: for static methods) is removed from trace entries before formatting, simplifying the error output.
- Modified the
getErrorPlace()method to filter out thetypekey from stack traces - Updated 48 test fixture files to reflect the removal of the
type=->line from error trace output
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Services/SwaggerService.php | Added Arr::forget() call to remove the 'type' key from trace entries before formatting |
| tests/fixtures/SwaggerServiceTest/*.html | Updated all 48 fixture files to remove the type=-> line from expected error output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenTray
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.